Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very early look into using swc instead of acorn + acorn-typescript to parse (see #13439)
So far I've just implemented parse_expression_at, which was the main blocker keeping acorn necessary. 238 test failures right now, most due to error messages not being the same, some due to hacks put in place to appease acorn-typescript.
This is really just a proof-of-concept. Instead of using swc's estree compat layer, it would be better to use their AST representation (which has full types available at
@swc/types
and would be compatible with theirprint
function to avoid a dependency onesrap
).To run:
rustup default nightly
) - this is a requirement ofswc_estree_compat
which could be removed by using their AST as mentioned abovecargo install cargo-watch
) for dev modepackages/swc-svelte
and runpnpm dev
to build the rust crateBefore submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint